Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

events: support dispatching event from event #33624

Closed
wants to merge 5 commits into from
Closed

events: support dispatching event from event #33624

wants to merge 5 commits into from

Conversation

benjamingr
Copy link
Member

Currently our events guard against dispatching an event from itself by type rather than by event instance. This makes a WPT test fail.

Here's some code to demonstrate the issue.

{
  const target = new EventTarget();
  const event = new Event('foo');
  let callCount = 0;
  target.addEventListener('foo', (() => {
    callCount++;
    if (callCount < 5) {
      target.dispatchEvent(new Event('foo'));
    }
  }, 5));
  console.log(callCount)
}

Dispatching an event while handling it is still not supported (as required).

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@benjamingr benjamingr added the events Issues and PRs related to the events subsystem / EventEmitter. label May 28, 2020
@benjamingr benjamingr requested a review from jasnell May 28, 2020 19:04
@benjamingr benjamingr mentioned this pull request May 28, 2020
Closed
4 tasks
@benjamingr
Copy link
Member Author

@jasnell I think you might have missed this one :]

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31654/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 30, 2020
@BridgeAR BridgeAR force-pushed the master branch 2 times, most recently from 8ae28ff to 2935f72 Compare May 31, 2020 12:18
@BridgeAR BridgeAR force-pushed the event-target-fix-recursion branch from adaed1b to f24f1b5 Compare May 31, 2020 13:38
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31680/

This was referenced Jun 1, 2020
Closed
Closed
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31766/

This was referenced Jun 9, 2020
Open
Open
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31825/

@jasnell
Copy link
Member

jasnell commented Jun 17, 2020

Ping @benjamingr ... tests are failing on this one.

@github-actions github-actions bot mentioned this pull request Jun 18, 2020
Open
18 tasks
@jasnell jasnell added eventtarget Issues and PRs related to the EventTarget implementation. and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Jun 19, 2020
@benjamingr
Copy link
Member Author

@jasnell sorry, I was (mostly) AFK and am (mostly) AFK for the coming week (except the summit). I will do one pass over all the PRs you pinged me at and fix/rebase them over master.

I feel like this landing part is harder than it should so feel free to either squash them all into one PR and land it as one change, or to just make all the changes directly (I really don't mind the git attribution being precise) or whatever is most convenient to you.

Again: my objective is to be helpful and to do the least toe-stepping :]

@benjamingr
event: cancelBubble is a property
3fff349 
Event#cancelBubble is property (and not a function). Change
Event#cancelBubble to a property and add a test.

PR-URL: nodejs#33613
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
@benjamingr
events: add event-target tests
d2b9e56 
PR-URL: nodejs#33623
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@jasnell
Copy link
Member

jasnell commented Jun 21, 2020

@benjamingr ... yeah, it's been pretty painful doing these piece by piece. I think I'll go ahead and combine all the changes into a single PR.

@benjamingr
Copy link
Member Author

@jasnell I am starting to see what you meant by "take it to a vendored dep" back then :]

Anyway, whatever is easiest and least painful for you. Another thing we can do is open one PR that will stay open for a few days on a branch, then we can push all the changes to that branch and merge that after a few days or something.

@jasnell jasnell mentioned this pull request Jun 22, 2020
Closed
3 tasks
@jasnell
Copy link
Member

jasnell commented Jun 22, 2020

Closing in favor of #34015 (which combines this and other eventtarget PRs into a single to make landing easier

@jasnell jasnell closed this Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
events Issues and PRs related to the events subsystem / EventEmitter. eventtarget Issues and PRs related to the EventTarget implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@benjamingr @nodejs-github-bot @jasnell @BridgeAR